Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Clean up. #27975

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Examples: Clean up. #27975

merged 2 commits into from
Mar 23, 2024

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Mar 23, 2024

Related issue: N/A

Description

  • The boolean parameter is ineffectual, so I removed it.
  • The camera updates seem to be for an OrthographicCamera, but a PerspectiveCamera is being used, so I updated them to make sense for a PerspectiveCamera.

@RenaudRohlinger RenaudRohlinger added this to the r163 milestone Mar 23, 2024
@RenaudRohlinger RenaudRohlinger merged commit 85e39c0 into mrdoob:dev Mar 23, 2024
11 checks passed
@Methuselah96 Methuselah96 deleted the patch-1 branch March 23, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants