ShaderLib: Clean up #27936
Merged
ShaderLib: Clean up #27936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
commented
Mar 17, 2024
| @@ -93,7 +93,7 @@ const ShaderLib = { | |||
| emissive: { value: /*@__PURE__*/ new Color( 0x000000 ) }, | |||
| roughness: { value: 1.0 }, | |||
| metalness: { value: 0.0 }, | |||
| envMapIntensity: { value: 1 } // temporary | |||
There was a problem hiding this comment.
I market this as 'temporary' in the original MeshStandardMaterial PR (#7381) because I felt the environmant map intensity should be a property of the environment map, not the material.
But it has turned out not to be temporary after all...
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup.