Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object3D: Fix events in attach(). #27917

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Object3D: Fix events in attach(). #27917

merged 1 commit into from
Mar 14, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 14, 2024

Fixed #26739.

Description

This PR fixes #26739 by inlining the relevant code of add() and is a simplified version of #26750.

@Mugen87 Mugen87 added this to the r163 milestone Mar 14, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
669.7 kB (166.1 kB) 669.8 kB (166.1 kB) +98 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.9 kB (108.8 kB) 450 kB (108.8 kB) +98 B

@Mugen87 Mugen87 changed the title Object3D: Fix added event in attach(). Object3D: Fix events in attach(). Mar 14, 2024
@Mugen87 Mugen87 merged commit 74252e6 into mrdoob:dev Mar 14, 2024
12 checks passed
@ycw
Copy link
Contributor

ycw commented Mar 18, 2024

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Object3D .attach() emits added too early
2 participants