Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Scene.environmentIntensity #27903

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

WestLangley
Copy link
Collaborator

As suggested in #24665 (comment).

Currently, material.envMapIntensity attenuates both scene.environment and material.envMap.

With this change, material.envMapIntensity attenuates only material.envMap.

A new property scene.environmentIntensity is introduced that attenuates only scene.environment.

@WestLangley WestLangley added this to the r163 milestone Mar 12, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
669.7 kB (166.2 kB) 670 kB (166.2 kB) +344 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.9 kB (108.8 kB) 450.2 kB (108.8 kB) +263 B

@WestLangley WestLangley changed the title Introduce Scene.environmentIntensity Introduce Scene.environmentIntensity Mar 12, 2024
@Mugen87 Mugen87 merged commit f9d9e6b into mrdoob:dev Mar 19, 2024
12 checks passed
@WestLangley WestLangley deleted the dev-environment_intensity branch March 19, 2024 16:11
@rndexe rndexe mentioned this pull request Jul 30, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants