WebGLRenderer: Fix transmission with nested render calls. #27886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Mar 8, 2024
| textureWidth: window.innerWidth * window.devicePixelRatio, | ||
| textureHeight: window.innerHeight * window.devicePixelRatio | ||
| textureWidth: window.innerWidth, | ||
| textureHeight: window.innerHeight |
There was a problem hiding this comment.
I've decreased the resolution a bit otherwise rendering becomes too fragment shader heavy.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #27846.
Description
This PR makes sure transmission can be used when a scene is rendered with nested render calls which is for example true when using mirrors. This fixes the instance of
Reflectorin thewebxr_vr_sandboxexample which was also reported in #27846.Thanks to @LR17's research we know now that without this change the contents of the (single) transmission render target would be overwritten. By having a render target for each render state, this does not happen anymore.