Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spherical: Clean up. #27848

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Spherical: Clean up. #27848

merged 3 commits into from
Mar 1, 2024

Conversation

davcri
Copy link
Contributor

@davcri davcri commented Feb 29, 2024

Description

  • Put JSDoc on the line before the class definition so that IDEs can pick it up correctly.
  • specify the used spherical convention

EG: this allows getting JSDoc while hovering over the Spherical class symbol.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
669.6 kB (166.2 kB) 669.6 kB (166.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.8 kB (108.8 kB) 449.8 kB (108.8 kB) +0 B

@Mugen87 Mugen87 merged commit 9fe9223 into mrdoob:dev Mar 1, 2024
10 of 11 checks passed
@Mugen87 Mugen87 added this to the r163 milestone Mar 1, 2024
@Mugen87 Mugen87 changed the title Spherical: improve JSDoc Spherical: Clean up. Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r163
Development

Successfully merging this pull request may close these issues.
2 participants
@davcri @Mugen87