WebGPURenderer: Added sync render()/clear() #27840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunag
changed the title
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27597 (comment), #26964
Description
On some Nodes including PMREMGenetaror(WebGPU) that is being developed, we will need to do render call synchronized in the same render pass, so as not to confuse the stack and don't have
race conditionproblem. The best alternative I found so far was to alert the user with an error if they callsrender()before initialization and directing them to userenderAsync()THREE.Renderer: .render() called before the backend is initialized. Try using .renderAsync() instead.