Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Added pointer cursor to summary tags. #27837

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

Therobo77
Copy link
Contributor

… a details element. Enhances user experience for interaction with details disclosure.

Added a CSS, pointer cursor when hovering over the summary tag within a details element. Enhances user experience for interaction with details disclosure.

It is more apealing.

Related issue: #XXXX

Description

A clear and concise description of what the problem was and how this pull request solves it.

This contribution is funded by Example

… a details element. Enhances user experience for interaction with details disclosure.

Added a CSS, pointer cursor when hovering over the summary tag within a details element. Enhances user experience for interaction with details disclosure.

It is more apealing.
@mrdoob
Copy link
Owner

mrdoob commented Feb 29, 2024

Do you mind sharing a screen recording of what this PR does?

@Mugen87 Mugen87 closed this Sep 19, 2024
@Mugen87 Mugen87 added this to the r169 milestone Sep 19, 2024
@Mugen87 Mugen87 reopened this Sep 19, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 19, 2024

This is actually a nice improvement. There are collapse UI elements in the Installation guide based on the summary tag like:

image

Currently, there is the normal text cursor symbol when hovering. With this PR, you get a pointer icon which makes it more clear the UI element is clickable.

Clean up.
@Mugen87 Mugen87 merged commit 944419f into mrdoob:dev Sep 19, 2024
1 of 2 checks passed
@Mugen87 Mugen87 changed the title Added a CSS, pointer cursor when hovering over the summary tag within… Docs: Added pointer cursor to summary tags. Sep 19, 2024
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 20, 2024
mrdoob#27837)

* Added a CSS, pointer cursor when hovering over the summary tag within a details element. Enhances user experience for interaction with details disclosure.

Added a CSS, pointer cursor when hovering over the summary tag within a details element. Enhances user experience for interaction with details disclosure.

It is more apealing.

* Update page.css

Clean up.

---------

Co-authored-by: Michael Herzog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants