Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Remove WebGL 1 support. #27836

Merged
merged 1 commit into from
Feb 29, 2024
Merged

WebGLRenderer: Remove WebGL 1 support. #27836

merged 1 commit into from
Feb 29, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 28, 2024

Related issue: -

Description

We have deprecated WebGL 1 support in r153 which is almost a year ago. This PR eventually removes it from WebGLRenderer.

@Mugen87 Mugen87 added this to the r163 milestone Feb 28, 2024
Copy link

github-actions bot commented Feb 28, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
678.5 kB (168.6 kB) 669.6 kB (166.2 kB) -8.93 kB

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
458.8 kB (111.4 kB) 449.8 kB (108.8 kB) -9.03 kB

@Mugen87 Mugen87 force-pushed the dev1 branch 3 times, most recently from e991473 to 38cd0f7 Compare February 28, 2024 11:05
@Mugen87 Mugen87 marked this pull request as ready for review February 29, 2024 09:46
@Mugen87 Mugen87 merged commit 07ec4e8 into mrdoob:dev Feb 29, 2024
12 checks passed
@toji
Copy link
Contributor

toji commented Feb 29, 2024

Quite the milestone! Congrats!

Now when we can start plotting the removal of WebGL 2 in favor of WebGPU? 😆

@mrdoob
Copy link
Owner

mrdoob commented Mar 1, 2024

Let's regroup in 2034 😅

@alexkowel
Copy link

Just in case, if someone still needs WebGL 1.0, Verge3D will continue supporting the old standard for some time. Too many older iPhones are still around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants