OrbitControls: fix zoom-changed detection #27834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27831
At some point our logic for detecting
zoomChanged
was modified and it is currently not functioning properly. Currently, the changes are being detected by the condition that validates camera movement and not actual zoom, however this is unreliable as seen in the linked issue.I made sure to properly detect changes for every variation of zoom logic (ortho/persp for zoomToCursor and regular zoom).
Also took the opportunity to only set this variable if zoom was actually modified, and not every time it is attempted. This way, if the zoom event is triggered but camera is already clamped to min/max distance, an event won't be triggered falsely.