-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPURenderer: PMREM #27829
WebGPURenderer: PMREM #27829
Conversation
/fyi @elalish |
Very cool! Let me know if you run into any problems with it. |
Thanks @elalish , I imagine it was a lot of work create this code originally, I'm trying to follow it as close to the original as possible :) |
Thanks @sunag! That was probably my single biggest contribution to PBR, and written with only a few months of JS background, so I apologize if it's a bit hard to follow. |
Lets move this to the next milestone. |
@sunag Pretty sure this PR broke |
@RenaudRohlinger It's happening just in |
It's happening when the device is slow if I understand correctly. WebGPU backend being a lot faster seems to almost always avoid the issue but it does happen sometimes. |
The issue was related to unresolved texture in the loaders (slow internet). I updated the example and now handle better this kind of error in #27951 |
Description
PMREMGenerator
forWebGPURenderer
version, andpmremTexture( texture, uv, roughness )
TSL function.webgpu_pmrem_scene
webgpu_pmrem_equirectangular
webgpu_pmrem_cubemap
Example