BufferGeometry: Use dedicated BufferAttribute
API in computeTangents()
.
#27825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
This PR makes sure
computeTangents()
does not work on the raw buffer attribute arrays but uses the getters and setters ofBufferAttribute
as well asfromBufferAttribute()
instead. This makes sure the method works with interleaved data and is more consistent to otherBufferGeometry
methods.