Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferGeometry: Remove outdated advice from error message. #27824

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 26, 2024

Related issue: -

Description

This PR removes an outdated advice in an error message of computeBoundingBox() and computeBoundingSphere().

Setting frustumCulled to false does not prevent the engine from using bounding volumes, they are relevant in other basic features as well like depth sorting or ray casting.

@Mugen87 Mugen87 added this to the r162 milestone Feb 26, 2024
@Mugen87 Mugen87 merged commit 5e2397a into mrdoob:dev Feb 26, 2024
10 of 11 checks passed
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
678.6 kB (168.7 kB) 678.5 kB (168.7 kB) -102 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
458.9 kB (111.4 kB) 458.8 kB (111.4 kB) -102 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant