OrbitControls: Ensure interceptControlDown() listener is removed in dispose().
#27778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up.
Mugen87
approved these changes
Feb 19, 2024
Mugen87
changed the title
interceptControlDown() listener is removed in dispose().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#27446 never seems to remove the
interceptControlDown()from thekeydownevent of thedocument. I found that this caused the memory leak during my memory leak troubleshooting, so I addedremoveEventListenertodispose().Please feel free to correct me if my understanding is wrong, thanks.