Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object3D: Reuse the child added and child removed events #27754

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #16934 (comment)

Description

Re use the child added and child removed event objects.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
676.4 kB (168.2 kB) 676.4 kB (168.3 kB) +68 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.2 kB (111 kB) 457.3 kB (111 kB) +68 B

@gkjohnson gkjohnson requested a review from Mugen87 February 16, 2024 12:13
@Mugen87 Mugen87 added this to the r162 milestone Feb 16, 2024
@gkjohnson gkjohnson merged commit 2fdc9ae into mrdoob:dev Feb 16, 2024
12 checks passed
@gkjohnson gkjohnson deleted the reuse-event branch February 16, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants