TSL: parallaxUV
#27739
Merged
TSL: parallaxUV
#27739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wooow! |
This was referenced Feb 22, 2024
WestLangley
reviewed
Feb 29, 2024
Comment on lines
+70
to
+77
| const roughnessTexture = loader.load( 'textures/ambientcg/Ice002_1K-JPG_Roughness.jpg' ); | ||
| roughnessTexture.colorSpace = THREE.SRGBColorSpace; | ||
|
|
||
| const normalTexture = loader.load( 'textures/ambientcg/Ice002_1K-JPG_NormalGL.jpg' ); | ||
| normalTexture.colorSpace = THREE.NoColorSpace; | ||
|
|
||
| const displaceTexture = loader.load( 'textures/ambientcg/Ice002_1K-JPG_Displacement.jpg' ); | ||
| displaceTexture.colorSpace = THREE.SRGBColorSpace; |
There was a problem hiding this comment.
roughness and displacement should be NoColorSpace.
And likewise, the normal texture, but its color profile is sRGB. Regardless, I'd leave it as NoColorSpace.
/ping @donmccurdy for second opinion.
There was a problem hiding this comment.
Agreed, we should use NoColorSpace for all textures containing non-color data, including all three here. The color profiles tend to be unreliable, and I'm not sure there's any way to tag an image clearly identifying it as non-color data. If the material looks incorrect when non-color textures are annotated with NoColorSpace, then we would need fix the textures.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
parallaxUVcan offer a depth effect in the material without needing RTT. Many effects such as car painting, ice, some types of water use this effect.Usage:
Live demo