-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPURenderer: support clipping #27691
Conversation
I guess we should support arbitrary types. |
I was wondering what method to use as opposed to which types. This approach just detects an array 'value' in the Uniform code and UniformGroups then handles arrays as part of the existing path. Or should NodeBuilder allocate a 'Vec{n}ArrayNodeUniform' etc which requires more boilerplate classes. There is an ArrayUniformNode too, but that doesn't appear to be used anywhere yet, and this works with a standard uniform() node. |
|
b5e3de1
to
e946976
Compare
e946976
to
3ca3fb3
Compare
bb974b0
to
ab19e46
Compare
Maybe we need to add |
This now uses uniforms(). I'm not sure what is going on with the screen shot failure. The major area of difference is the bottom edge which isn't subject to clipping. |
We commented at the same time. |
Supports global and material bases clipping.
Notes:
This can be extended to support a ClippingGroup() as mentioned at:
three.js/src/renderers/WebGLRenderer.js
Lines 1783 to 1786 in a2bf250
Fixes shadow handling of shadow side.
Added support for uniform arrays for vec4 only. Is this method ok or is a full set of ArrayUniform and ArrayNodeUniform classes prefered?