-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGLRenderer: Remove unnecessary __hasExternalTextures
check.
#27684
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
__hasExternalTextures
check.
@Mugen87 I have question about |
|
That code is used in other places so it's needed. Specifically, if an experience passes a color and depth buffer and tries to use this extension, we will disable the extension and print this warning. |
That extension is supported by the Quest (and possibly Pico) browser to do efficient multisampled rendering |
Description
renderTargetProperties.__hasExternalTextures
is set betrue
just one line above if statement, so I think if can be removed.Also move some variables to proper place.