Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EllipseCurve: Use ES6 default parameters in getPoint(). #27677

Merged
merged 1 commit into from
Feb 4, 2024
Merged

EllipseCurve: Use ES6 default parameters in getPoint(). #27677

merged 1 commit into from
Feb 4, 2024

Conversation

linbingquan
Copy link
Contributor

Related issue: #XXXX

Description

Use ES6 default parameters for EllipseCurve.getPoint

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
674.2 kB (167.5 kB) 674.2 kB (167.5 kB) -1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
455.1 kB (110.5 kB) 455.1 kB (110.5 kB) +0 B

@Mugen87 Mugen87 changed the title src: Use ES6 default parameters. EllipseCurve: Use ES6 default parameters in getPoint(). Feb 4, 2024
@Mugen87 Mugen87 added this to the r162 milestone Feb 4, 2024
@Mugen87 Mugen87 merged commit 5e2a002 into mrdoob:dev Feb 4, 2024
12 checks passed
@Methuselah96 Methuselah96 mentioned this pull request Feb 6, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r162
Development

Successfully merging this pull request may close these issues.
2 participants
@linbingquan @Mugen87