Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: support mat2() and extend RotateNode to support vec2 rotation. #27612

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

aardgoose
Copy link
Contributor

As title.

Also use RotateNode in SpriteNodeMaterial and RotateUVNode.

@sunag sunag added this to the r161 milestone Jan 23, 2024
@sunag sunag merged commit 59ceca2 into mrdoob:dev Jan 23, 2024
11 checks passed
@aardgoose aardgoose deleted the mat2 branch January 24, 2024 14:46
@@ -575,6 +575,7 @@ class NodeBuilder {

if ( vecNum !== null ) return Number( vecNum[ 1 ] );
if ( vecType === 'float' || vecType === 'bool' || vecType === 'int' || vecType === 'uint' ) return 1;
if ( /mat2/.test( type ) === true ) return 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how simple it was to introduce a new type!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants