Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXR: optional onLoad callback when loading hands or controllers #27544

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

hybridherbst
Copy link
Contributor

Closes

Description

Alternative approach to be able to react to hand and controller models actually being loaded. The callback allows setting layers, adjusting materials, ... on the loaded meshes/objects once the internal loading routines are actually done.

This contribution is funded by Needle

Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach more than #23279 since a onLoad() callback is the more generic solution and can be useful for different use cases.

@Mugen87 Mugen87 added this to the r161 milestone Jan 11, 2024
@Mugen87 Mugen87 merged commit d25f427 into mrdoob:dev Jan 15, 2024
11 checks passed
@hybridherbst hybridherbst deleted the feature/webxrhands-onload branch January 15, 2024 14:54
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
…rdoob#27544)

* WebXR: add onLoad callback for XRHandMeshModel

* add onLoad for XRControllerModelFactory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants