Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: PassNode + PostProcessing - WebGPUBackend #27537

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jan 10, 2024

Description

HDR PostProcessing and Refraction example.

webgpu_backdrop_water

image

Underwater

image

@mrdoob
Copy link
Owner

mrdoob commented Jan 11, 2024

Looking good! ✨

@mrdoob
Copy link
Owner

mrdoob commented Jan 11, 2024

By the way, Chrome Canary in Android already has WebGPU enabled.

However, for some reason, weed the example loads the camera seems to be zoomed in.

Screenshot_20240111-063255

But after tapping the screen the issue goes away.

Screenshot_20240111-063307

It may be something to do with lil-gui?

@sunag
Copy link
Collaborator Author

sunag commented Jan 12, 2024

@mrdoob I was able to reproduce the problem, clicking on the menu (three vertical dots) -> Settings -> Accessibility I activated Force enable zoom.

Maybe it's not a bug, but a special browser setting?

WhatsApp Image 2024-01-12 at 16 55 29_3a18827b

@sunag sunag marked this pull request as ready for review January 15, 2024 18:15
@sunag sunag added this to the r161 milestone Jan 15, 2024
@sunag sunag changed the title WebGPURenderer: PassNode + PostProcessing WebGPURenderer: PassNode + PostProcessing - WebGPUBackend Jan 16, 2024
@sunag sunag merged commit 6a3efed into mrdoob:dev Jan 17, 2024
11 checks passed
@sunag
Copy link
Collaborator Author

sunag commented Jan 18, 2024

I didn't implement it in WebGLBackend, the example should work if copyFramebufferToTexture() uses the RenderTarget as a source if there is one.

/cc @RenaudRohlinger @aardgoose

@mrdoob
Copy link
Owner

mrdoob commented Jan 23, 2024

@mrdoob I was able to reproduce the problem, clicking on the menu (three vertical dots) -> Settings -> Accessibility I activated Force enable zoom.

Maybe it's not a bug, but a special browser setting?

Hmm...

Screenshot_20240123-163539

These are my settings... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants