Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLCubeMaps: Increase size of internal cube maps. #27530

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 9, 2024

Fixed #27501.

Description

This PR increases the size of internal cube maps generated from equirectangular environment maps in order to avoid undersampling which results in blurrier output compared to the original texture.

Copy link

github-actions bot commented Jan 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
671.2 kB (166.8 kB) 671.2 kB (166.8 kB) -2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
452.2 kB (109.8 kB) 452.2 kB (109.8 kB) -2 B

@Mugen87 Mugen87 added this to the r161 milestone Jan 9, 2024
@Mugen87 Mugen87 marked this pull request as ready for review January 9, 2024 09:41
@Mugen87 Mugen87 merged commit 79621cf into mrdoob:dev Jan 9, 2024
12 checks passed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
* WebGLCubeMaps: Increase size of internal cube maps.

* Examples: Update screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a texture as scene.background is blurrier than it should
1 participant