WebGPURenderer: cache renderPassDesciptors and associated views. #27518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Some examples is Both stencilLoadOp (LoadOp::Clear) and stencilStoreOp (StoreOp::Store) must not be set if the attachment ([TextureView]) has no stencil aspect or stencilReadOnly (0) is true.
- While validating depthStencilAttachment.
- While encoding [CommandEncoder "renderContext_2"].BeginRenderPass([RenderPassDescriptor]). |
|
I'll have a look |
|
Renderer now sets correct depth and stencil values for renderContext objects, and depth / depth+stencil objects created as required. |
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
…oob#27518) * cache descriptors * check sample count for msaa targets * add missing ; * set renderContext depth/stencil state correctly --------- Co-authored-by: aardgoose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the default null renderTarget cache descriptor, depth texture view and msaa texture view where appropriate.
For non null targets, use the renderTarget as a key for caching renderPassDescriptors to reduce per pass object creation .
The default descriptor members could be reused in the clear() method.