Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display offersession promise failure instead of showing console errors #27492

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

cabanier
Copy link
Contributor

@cabanier cabanier commented Jan 3, 2024

A developer complained that when they put multiple buttons on the page, they get errors in the js console.
These errors are harmless failed promises from offerSession but they claim that people don't like to see errors in the console.
This PR will catch the failed promises and show them as console warnings

This contribution is funded by Meta

@cabanier cabanier marked this pull request as ready for review January 3, 2024 18:07
@Mugen87 Mugen87 added this to the r161 milestone Jan 4, 2024
@Mugen87 Mugen87 merged commit a4fbc07 into mrdoob:dev Jan 5, 2024
11 checks passed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
mrdoob#27492)

* display offersession promise failure instead of showing console errors

* change log() to warn() for offersession handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants