Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio: Make setDetune() more robust. #27479

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Audio: Make setDetune() more robust. #27479

merged 1 commit into from
Dec 31, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 31, 2023

Fixed #27477.

Description

Now the code only checks for source.detune when the audio is playing. That ensures an audio source is defined.

@Mugen87 Mugen87 added this to the r161 milestone Dec 31, 2023
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
671 kB (166.8 kB) 671 kB (166.8 kB) -1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
451.9 kB (109.8 kB) 451.9 kB (109.8 kB) +0 B

@Mugen87 Mugen87 merged commit 1d57f1c into mrdoob:dev Dec 31, 2023
12 checks passed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in Audio.js setDetune
1 participant