Addons: Auto-fix linting problems #27457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings 93 problems (60 errors, 33 warnings) down to 37 problems (4 errors, 33 warnings).
Mugen87
approved these changes
Dec 27, 2023
hybridherbst
added a commit
to needle-tools/three.js
that referenced
this pull request
Dec 27, 2023
Brings 93 problems (60 errors, 33 warnings) down to 37 problems (4 errors, 33 warnings).
hybridherbst
added a commit
to needle-tools/three.js
that referenced
this pull request
Dec 27, 2023
Brings 93 problems (60 errors, 33 warnings) down to 37 problems (4 errors, 33 warnings).
hybridherbst
added a commit
to needle-tools/three.js
that referenced
this pull request
Dec 27, 2023
Brings 93 problems (60 errors, 33 warnings) down to 37 problems (4 errors, 33 warnings).
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
Brings 93 problems (60 errors, 33 warnings) down to 37 problems (4 errors, 33 warnings).
|
@LeviPesin I'd be very much in favor of that, but before it can be enabled there would be the above mentioned 37 errors and warnings to resolve, which I don't know how to resolve. |
|
Hm... I can try to look into them after I'll file the nodes PRs I'm planning soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running the automatic linting fix (
npm run lint-addons -- --fix) brings 93 problems (60 errors, 33 warnings) down to 37 problems (4 errors, 33 warnings) and makes it a bit easier to adhere to the coding standards in new files and PRs.This contribution is funded by Needle