WebGPURenderer: New AfterImageNode for the PostProcessing renderer.
#27451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a good policy since it allows to offer replacement nodes for existing pass classes. |
45 tasks
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
…mrdoob#27451) * init afterimage node * init value * cleanup ---------
LeviPesin
reviewed
Jan 19, 2024
| @@ -111,6 +111,8 @@ export { default as ViewportSharedTextureNode, viewportSharedTexture } from './d | |||
| export { default as ViewportDepthTextureNode, viewportDepthTexture } from './display/ViewportDepthTextureNode.js'; | |||
| export { default as ViewportDepthNode, viewZToOrthographicDepth, orthographicDepthToViewZ, viewZToPerspectiveDepth, perspectiveDepthToViewZ, depth, depthTexture, depthPixel } from './display/ViewportDepthNode.js'; | |||
| export { default as GaussianBlurNode, gaussianBlur } from './display/GaussianBlurNode.js'; | |||
| export { default as AfterImageNode, afterImage } from './display/AfterImageNode.js'; | |||
There was a problem hiding this comment.
@sunag Maybe we can create a new directory for postprocessing nodes (GaussianBlur, AfterImage), like postprocessing/?
There was a problem hiding this comment.
Interesting, filters seem to sound better to me, I don't think they should be for exclusive use in post-processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a temporal node that can be use in the postprocessing pipeline. I took the opportunity to create a new gpu postprocessing demo. It's called
AfterImageNodeto be aligned with the legacy nameAfterimagePass.Example on how to use it with the
afterImagemethod:Demo:
https://raw.githack.com/renaudrohlinger/three.js/node-temporal/examples/webgpu_postprocessing_afterimage.html