Grounded Skybox

[elalish]

Fixes #27422

Description

As requested; I've simplified it a bit too, as well as removed the GUI from the example since the parameters are not really meant to be tweaked realtime.

[Mugen87]

For comparison:

https://rawcdn.githack.com/elalish/three.js/groundedSkybox/examples/webgl_materials_envmaps_groundprojected.html
https://threejs.org/examples/webgl_materials_envmaps_groundprojected.html

[Mugen87]

The E2E screenshot needs an update via npm run make-screenshot webgl_materials_envmaps_groundprojected.

[marcofugaro]

Maybe it makes sense to convert the HDR to .jpg like in #27183 for this particular example?

[elalish]

Maybe it makes sense to convert the HDR to .jpg like in #27183 for this particular example?

Probably, but let's leave that to another PR. Ideally once UltraHDR support comes to core - 🙏 @mrdoob!

[elalish]

Hmm, make-screenshot gave me a black image. It used to work fine on this macbook, but it also used to open Chrome - it seems to be headless now? I wonder if that's related...

Meantime, can someone else generate the screenshot?

[mrdoob]

Seems like it worked on my machine... fc885c5 🤔

[hybridherbst]

@elalish is there a reason for not setting depthWrite = false on the material? Can I make a PR?

I adjusted depthWrite in this PR as well:

• GroundedSkybox: Fix UVs being flipped #27500

[timothyallan]

Fixes #27422

Description

As requested; I've simplified it a bit too, as well as removed the GUI from the example since the parameters are not really meant to be tweaked realtime.

I run a builder type site where people used to be able to tweak the parameters in real time to get their content to display the way they wanted. Is the best way now to just delete/recreate via new GroundedSkybox() when updating params?

[Mugen87]

Yes. Remove the skybox from the scene and then call dispose() on its geometry and material to make sure to clean things up. You can then setup a new instance.

[timothyallan]

Yep, the types showed there was no .dispose(), but after checking out the code and seeing how the new code is actually structured, that's exactly what I'm doing now. Thanks.

[mrdoob]

I run a builder type site where people used to be able to tweak the parameters in real time to get their content to display the way they wanted.

@timothyallan do you have a link to that site?

[timothyallan]

@timothyallan do you have a link to that site?

It's part of a new suite of 3d tooling being added to an existing SaaS platform. We've been beta testing it all for the past few months, and it's not available to the general public yet. It's good this update happened now actually!