LUT Loaders: Add support for FloatType and add docs #27431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Dec 24, 2023
Mugen87
reviewed
Dec 24, 2023
gkjohnson
reviewed
Dec 25, 2023
There was a problem hiding this comment.
Thanks! One comment but this looks good otherwise.
Here's a live demo of the LUT page with this PR:
https://raw.githack.com/vanruesc/three.js/lut-loaders/examples/webgl_postprocessing_3dlut.html
Also it occurs to me that with webgl1 support being dropped in r163 we'll be able to drop support for loading 2d lut textures with these!
45 tasks
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
* Update LUT loaders * Add docs for LUT loaders * Fix lint issues * Update list.json * Add module name to error messages * Remove unnecessary code * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the LUT loaders
LUT3dlLoaderandLUTCubeLoaderto supportFloatTypedata. I've also refactored the code based on the classes LUT3dlLoader and LUTCubeLoader from@pmndrs/postprocessingand added doc pages.The following sandbox can be used to verify that the new loaders return the same results as the old ones when the type is set to
UnsignedByteType(default): https://codesandbox.io/p/sandbox/lut-loader-test-dhprvp