Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrbitControls: fix Orthographic 'change' event #27424

Merged
merged 3 commits into from
Dec 24, 2023

Conversation

sciecode
Copy link
Contributor

Fixes #27280

Prevents OrthographicCamera from triggering change event every frame.

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 23, 2023

The PR indeed fixes the issue! Here is the code I have tested with: https://jsfiddle.net/13Ltqzye/

@Mugen87 Mugen87 added this to the r161 milestone Dec 23, 2023
Signed-off-by: Guilherme Avila <[email protected]>
@Mugen87 Mugen87 merged commit a797aca into mrdoob:dev Dec 24, 2023
11 checks passed
@sciecode sciecode deleted the dev-orbit-change branch December 24, 2023 18:53
@jedleslie
Copy link

You all rule. Thanks for all you do!

AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
* OrbitControls: fix Orthographic 'change' event

Signed-off-by: Guilherme Avila <[email protected]>

* OrbitControls: only recalculate when zoom has changed

Signed-off-by: Guilherme Avila <[email protected]>

* clean-up

Signed-off-by: Guilherme Avila <[email protected]>

---------

Signed-off-by: Guilherme Avila <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrbitControls update event always fired if using an Orthographic Camera
3 participants