Timer: Add optional timestamp
parameter.
#27421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #17912
Description
This PR continues the discussion from #17912 (comment).
I've added an optional
timestamp
parameter toTimer.update()
that allows the user to pass the same timestamp to multiple timers. This also avoids unnecessary calls toperformance.now()
when using requestAnimationFrame because the callback already receives a timestamp argument.@Mugen87 previously raised some concerns regarding this parameter:
We can clarify in the docs that using a
fixedDelta
overrides dynamic time deltas. I'm not sure if thetimestamp
parameter would somehow interfere with_startTime
. Shouldn't this just work as ifperformance.now()
was used?