Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: bug fixes for WebGLBackend #27410

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

aardgoose
Copy link
Contributor

Related issue: #27400

Multiple RenderTargets may map to a single RenderContext so we can't cache framebuffers by RenderContext. Pass RenderTarget to use as cache key for framebuffers. Exposed by the compute_snow example which otherwise works with #27367.

Also add missing temporary framebuffer deletion.

@aardgoose aardgoose marked this pull request as ready for review December 20, 2023 14:32
@aardgoose aardgoose changed the title WebGPURenderer: bug fixes for WebGLBsackend WebGPURenderer: bug fixes for WebGLBackend Dec 20, 2023
@sunag sunag added this to the r160 milestone Dec 20, 2023
@sunag sunag merged commit 4acb780 into mrdoob:dev Dec 20, 2023
11 checks passed
@aardgoose aardgoose deleted the webgl-rt-fix branch December 20, 2023 20:31
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants