USDZExporter: export from compressed texture data #23321 #27382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Dec 14, 2023
Clean up.
Mugen87
reviewed
Dec 14, 2023
| @@ -1,5 +1,6 @@ | |||
| import * as THREE from 'three'; | |||
There was a problem hiding this comment.
Side note: It's not good that USDZExporter imports the entire core. Like all other modules, the exporter should only import what is actually required. This should be fixed with another PR.
There was a problem hiding this comment.
Agreed, I'll plan on submitting a separate PR once/if this is merged.
jeffbeene
added a commit
to jeffbeene/three.js
that referenced
this pull request
Dec 15, 2023
Mugen87
pushed a commit
that referenced
this pull request
Dec 15, 2023
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
…b#27382) * USDZExporter: export from compressed texture data mrdoob#23321 * add screenshot, update files.json * Update USDZExporter.js Clean up. * remove usdz compressed example * Update USDZExporter.js --------- Co-authored-by: Michael Herzog <[email protected]>
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23321
Implement TextureUtils
decompressfunction in USDZExporter, allowing export of compressed meshes and textures (e.g. draco + ktx2)Based on work by @hybridherbst introduced here: 706e9cf