WebGLUniformsGroups: Fix and improve UBOs array caching system #27374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Yes, this is supported. https://jsfiddle.net/c8oydmk9/ |
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
…b#27374) * fix and improve UBOs array caching system * simplify cache check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing array of UBOs I realized that the caching system was only taking in consideration the first entry of an array of uniform.
I refactored the caching system with using a
uniformIndex_uniformIndexInArraykey system to fix this.Also the caching system was handling basic arrays which is something that
WebGLUniformsGroupsdoesn't support yet. Not sure if Uniforms in threejs supports basic arrays OOTB (for exampleUniform( [0,1,2] )instead ofUniform( new THREE.Vector3(0,1,2) ))?Currently it adds unnecessary complexity to the caching system and anyway support is not there so I removed it.