Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XR buttons: Add support for offerSession(). #27359

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

cabanier
Copy link
Contributor

@cabanier cabanier commented Dec 11, 2023

offerSession is a recent addition to WebXR that makes it more obvious that a page can enter WebXR.
Quest browser got feedback that the "Enter VR/AR/XR" buttons on a lot of sites is hard to find. Often the button is small or scrolled of the bottom of the page. To remedy this, we worked with the W3C Immersive group on a new API that adds a button to the URL bar. This button will launch a pending immersive session.

This change adds support for this new API. Authors are free to use it or comment it out if they prefer to only allow their own UI.

cc @mrdoob

This contribution is funded by Meta

examples/jsm/webxr/VRButton.js Fixed Show fixed Hide fixed
examples/jsm/webxr/VRButton.js Fixed Show fixed Hide fixed
@cabanier cabanier marked this pull request as ready for review December 11, 2023 18:36
@Mugen87 Mugen87 added this to the r160 milestone Dec 11, 2023
@Mugen87 Mugen87 merged commit 11ad176 into mrdoob:dev Dec 12, 2023
11 checks passed
@Mugen87 Mugen87 changed the title Add support for offerSession XR buttons: Add support for offerSession(). Dec 12, 2023
@Mugen87 Mugen87 mentioned this pull request Dec 12, 2023
@cabanier cabanier deleted the offersession branch December 12, 2023 17:51
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants