Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaders: Remove unused defines. #27346

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Shaders: Remove unused defines. #27346

merged 1 commit into from
Dec 10, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 9, 2023

Description

Remove some unused definitions in cube_uv_reflection_fragment.glsl.js.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
669 kB (166.1 kB) 668.9 kB (166.1 kB) -136 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.9 kB (109 kB) 449.7 kB (109 kB) -136 B

@sunag sunag marked this pull request as ready for review December 10, 2023 07:18
@Mugen87 Mugen87 added this to the r160 milestone Dec 10, 2023
@Mugen87 Mugen87 merged commit 5a675e6 into mrdoob:dev Dec 10, 2023
12 checks passed
@Mugen87 Mugen87 changed the title Core: Remove defines unused. Shaders: Remove unused defines. Dec 10, 2023
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
@sunag @AdaRoseCannon
Core: Remove some defines unused (mrdoob#27346)
8b87a7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r160
Development

Successfully merging this pull request may close these issues.
2 participants
@sunag @Mugen87