Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Area Lights: Only use float textures if linear interpolation is supported #27315

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Dec 5, 2023

Fixed #27305

Description

The WebGLLights file was incorrectly assuming that interpolating float textures was always possible in WebGL2. I'm unable to test this on ios so if someone else can confirm that this addresses the issue that would be great.

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 5, 2023

Funny, we have filed a PR at the same time 😆 #27316.

@Mugen87 Mugen87 added this to the r160 milestone Dec 5, 2023
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confidently approve the PR!

Copy link

github-actions bot commented Dec 5, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
669.1 kB (166.1 kB) 669.3 kB (166.1 kB) +160 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
450.1 kB (109 kB) 450.3 kB (109.1 kB) +160 B

@gkjohnson
Copy link
Collaborator Author

Funny, we have filed a PR at the same time 😆 #27316.

Ha, to the minute! 🏁

@gkjohnson gkjohnson merged commit f4bc350 into mrdoob:dev Dec 5, 2023
12 checks passed
@gkjohnson gkjohnson deleted the fix-ios-arealights branch December 5, 2023 14:20
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RectAreaLight not reflecting correctly iOS Safari
2 participants