Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: copyTextureToTexture3D fix level mipmap and support CompressedArrayTexture #27313

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

RenaudRohlinger
Copy link
Collaborator

copyTextureToTexture3D doesn't currently support compressed texture. This PR fixes the issues.

Copy link

github-actions bot commented Dec 5, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
669.1 kB (166.1 kB) 669.1 kB (166.1 kB) +29 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
450.1 kB (109 kB) 450.1 kB (109 kB) +29 B

@Mugen87 Mugen87 added this to the r160 milestone Dec 5, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 5, 2023

Um, webgpu_morphtargets_face still fails. Can you try to revert the last commit?

Sometimes, screenshot tests fails because of a minor deviation. Triggering a new test via Re-run job usually solves these false alerts. So regenerating screenshots is not required.

@RenaudRohlinger
Copy link
Collaborator Author

Ah indeed it fixed it!

@Mugen87 Mugen87 merged commit 03c2218 into mrdoob:dev Dec 5, 2023
21 of 22 checks passed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants