Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DracoLoader: remove extra redundant code #27308

Merged

Conversation

Benjythebee
Copy link
Contributor

Quick removal of redundant code
see #27306 (comment)

@Benjythebee Benjythebee changed the title Fix/drac/remove extra redundant code DracoLoader: remove extra redundant code Dec 4, 2023
@Mugen87 Mugen87 marked this pull request as ready for review December 4, 2023 19:52
@Mugen87 Mugen87 added this to the r160 milestone Dec 4, 2023
@Mugen87 Mugen87 merged commit 139cbde into mrdoob:dev Dec 4, 2023
11 checks passed
@Benjythebee Benjythebee deleted the fix/drac/remove-extra-redundant-code branch December 4, 2023 20:56
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
* fix onError load

* onError

* LinearSRGBColorSpace instead of undefined

* default onError = () => {}; call onError to cleanup code;

* dracoloader: remove redundant catch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants