WebGPURenderer: MaterialX #27294
Merged
WebGPURenderer: MaterialX #27294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this E2E error have something to do with this PR? |
|
I'm not sure why but the error "TimeoutError: Navigation timeout of 300000 ms exceeded" seems to happen with random examples and then the run fails. It also seems to happen just in the |
|
Did another test run and now the timeout happens with |
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
* MathNode: Add `bitcast()` * WGSLNodeBuilder: Add `greaterThan` for vec3 * WGSLNodeBuilder: XOR * NodeBuilder: .buildFunctionNode() and getFunctionOperator() * TSL: Function Overloading * SplitNode: Fix expected output if used uvec or ivec * TSL Transpiler: Improvements and fixes * TSL: Fix expected output if used a.assign( b ), returns a * FIX & TODO: Check reasons * Fix clearcoat op sequence * WebGPURenderer: MaterialX Support * add webgpu materialx examples * fix backend name * unknown diff screenshot problem * testing e2e response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24707, closes #24958
Introduction
This PR introduces the first version of the
MaterialXlibrary forWebGPURenderer, compatible withWebGLRenderertoo using TSL.We were successful in converting
mx_noisetoTSLusing theThree.js Transpiler, making future updates easier.MaterialX Loader Example
MaterialX Noise Nodes
Description
--
--