Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: Add sorting and frustum culling for shadows #27258

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Nov 27, 2023

Related issue: #27250, #14921 (comment), #22376

Description

Fixes shadows disappearing when a batchedMesh sub-geometry is frustum culled offscreen by performing frustum culling and sorting in onBeforeShadow.

@gkjohnson gkjohnson added this to the r159 milestone Nov 27, 2023
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
668.6 kB (165.9 kB) 668.7 kB (166 kB) +62 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.8 kB (108.9 kB) 449.8 kB (108.9 kB) +0 B

@Mugen87 Mugen87 merged commit 15d7f23 into mrdoob:dev Nov 27, 2023
12 checks passed
@gkjohnson gkjohnson deleted the batched-mesh-shadows branch November 27, 2023 12:38
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants