Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: Move to core #27200

Merged
merged 1 commit into from
Nov 17, 2023
Merged

BatchedMesh: Move to core #27200

merged 1 commit into from
Nov 17, 2023

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Nov 17, 2023

Related issue: #22376, #27111

Description

Moves BatchedMesh into core.

Upcoming PRs

  • Maybe a little more code cleanup, I think

@gkjohnson gkjohnson requested review from mrdoob and Mugen87 November 17, 2023 09:50
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
668.4 kB (166.2 kB) 668.4 kB (166 kB) +18 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.4 kB (108.9 kB) 449.4 kB (108.9 kB) +0 B

@mrdoob mrdoob added this to the r159 milestone Nov 17, 2023
@mrdoob mrdoob merged commit b65ee86 into mrdoob:dev Nov 17, 2023
12 checks passed
@mrdoob
Copy link
Owner

mrdoob commented Nov 17, 2023

import {
	BufferAttribute,
	BufferGeometry,
	DataTexture,
	FloatType,
	MathUtils,
	Matrix4,
	Mesh,
	RGBAFormat,
	Box3,
	Sphere,
	Frustum,
	WebGLCoordinateSystem,
	WebGPUCoordinateSystem,
	Vector3,
} from 'three';

I'm fixing this 👍

@gkjohnson gkjohnson deleted the batched-mesh-core branch November 17, 2023 10:01
@gkjohnson
Copy link
Collaborator Author

I'm fixing this 👍

Oh! Sorry I missed that.

@mrdoob
Copy link
Owner

mrdoob commented Nov 17, 2023

2b3883a

AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants