Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Refactor creation of GLTFLoader. #27193

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Editor: Refactor creation of GLTFLoader. #27193

merged 1 commit into from
Nov 16, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 15, 2023

Related issue: -

Description

When working at #27191, I've noticed some code redundancy in editor's Loader file. There is now a new function createGLTFLoader() that creates and configures the loader for the different use cases.

This PR makes also sure dispose() is called for the instance of KTX2Loader similar to DRACOLoader.

@Mugen87 Mugen87 added this to the r159 milestone Nov 15, 2023
@Mugen87 Mugen87 merged commit 1d3baf4 into mrdoob:dev Nov 16, 2023
11 checks passed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant