Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLAttributes: Strict buffer size check when updating data. #27188

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

eXponenta
Copy link
Contributor

Strict check for buffer size while upload..

Related issue: #27180

Strict check for buffer size while upload..
Copy link

github-actions bot commented Nov 14, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
667.4 kB (165.9 kB) 667.6 kB (165.9 kB) +232 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.3 kB (108.8 kB) 449.5 kB (108.9 kB) +232 B

@eXponenta eXponenta changed the title Update WebGLAttributes.js Strict check while update WebGLAttributes data Nov 14, 2023
Implement the check even more strict. Clarify error message.
@Mugen87 Mugen87 changed the title Strict check while update WebGLAttributes data WebGLAttributes: Strict buffer size check when updating data. Nov 16, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 16, 2023

I've update the code too make the check even more strict.

@Mugen87 Mugen87 added this to the r159 milestone Nov 16, 2023
@mrdoob mrdoob merged commit b67767c into mrdoob:dev Nov 17, 2023
12 checks passed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
…#27188)

* Update WebGLAttributes.js

Strict check for buffer size while upload..

* fix: lint, pads

* Update WebGLAttributes.js

Implement the check even more strict. Clarify error message.

* Update WebGLAttributes.js

* Update WebGLAttributes.js

Fix typo.

---------

Co-authored-by: Michael Herzog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants