Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectLoader: Add support for BatchedMesh #27179

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #22376, #27111

Description

Add "ObjectLoader" support for BatchedMesh. Once BatchedMesh is merged in master I can fix the import.

@gkjohnson gkjohnson added this to the r159 milestone Nov 13, 2023
@gkjohnson gkjohnson requested a review from Mugen87 November 13, 2023 09:28
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
656.7 kB (162.8 kB) 667.4 kB (165.9 kB) +10.67 kB

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.2 kB (108.8 kB) 449.3 kB (108.8 kB) +57 B

@gkjohnson gkjohnson merged commit 99fd53f into mrdoob:dev Nov 13, 2023
12 checks passed
@gkjohnson gkjohnson deleted the object-loader-batched branch November 13, 2023 10:49
@mrdoob
Copy link
Owner

mrdoob commented Nov 17, 2023

https://threejs.org/examples/webgl_morphtargets_face.html

Yeah, we should probably move it to core now...

Screenshot 2023-11-17 at 6 09 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants