Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run e2e CI only on macos. #27165

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Run e2e CI only on macos. #27165

merged 11 commits into from
Nov 10, 2023

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Nov 10, 2023

Related issue: #XXXX

Description

I've been told that the macos vms do have a working gpu.
This PR aims to simplify the e2e setup to only run on those.

Copy link

github-actions bot commented Nov 10, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
656.7 kB (162.7 kB) 656.7 kB (162.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.2 kB (108.6 kB) 449.2 kB (108.6 kB) +0 B

test/e2e/puppeteer.js Fixed Show fixed Hide fixed
@mrdoob mrdoob added this to the r159 milestone Nov 10, 2023
@mrdoob mrdoob merged commit fe25aef into dev Nov 10, 2023
11 checks passed
@mrdoob mrdoob deleted the mrdoob-patch-1 branch November 10, 2023 06:46
@LeviPesin
Copy link
Contributor

I've been told that the macos vms do have a working gpu.

But I don't really think Puppeteer is able to use it for some reason... IIRC I only got WebGPU to run when using non-headless runs and fromSurface: false screenshots (and this worked on all 3 OSes).

So I don't really see a reason to only using one OS. /ping @mrdoob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants