Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octree: Add clear(). #27160

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Octree: Add clear(). #27160

merged 2 commits into from
Nov 17, 2023

Conversation

CahierX
Copy link
Contributor

@CahierX CahierX commented Nov 9, 2023

When I use octree, I need to reset octree in some scenarios, so I add the clear method

Repository owner deleted a comment from jabri62018 Nov 10, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 16, 2023 •
edited
Loading

I have slightly updated the clear() method and the ctor to make the code more consistent. Would this version of clear() work for you, too?

@Mugen87 Mugen87 added this to the r159 milestone Nov 16, 2023
@Mugen87 Mugen87 changed the title feature: add octree clear method Octree: Add clear(). Nov 16, 2023
@CahierX
Copy link
Contributor Author

CahierX commented Nov 17, 2023

I have slightly updated the clear() method and the ctor to make the code more consistent. Would this version of clear() work for you, too?

Yes, this version of clear() works for me as well.

@mrdoob mrdoob merged commit aa2cfc8 into mrdoob:dev Nov 17, 2023
11 checks passed
This was referenced Nov 18, 2023
Merged
Closed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
@CahierX @Mugen87 @AdaRoseCannon
Octree: Add clear(). (mrdoob#27160)
e4bfc5d 
* feature: add octree clear method

* Update Octree.js

---------

Co-authored-by: cahierchen <[email protected]>
Co-authored-by: Michael Herzog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r159
Development

Successfully merging this pull request may close these issues.
3 participants
@CahierX @Mugen87 @mrdoob