Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: Add object-level bounds #27145

Merged
merged 17 commits into from
Nov 8, 2023

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Nov 8, 2023

Related issue: #22376, #27111, #27120 (comment)

Depends on #27120 (must be merged first)

Description

Adds support for object-level bounding boxes to BatchedMesh.

Upcoming PRs

  • Raycasting, sorting support
  • Add support to ObjectLoader
  • Move to core
  • Documentation

@gkjohnson gkjohnson added this to the r159 milestone Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
655.7 kB (162.4 kB) 656 kB (162.5 kB) +228 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
448.4 kB (108.4 kB) 448.6 kB (108.5 kB) +228 B

@gkjohnson gkjohnson marked this pull request as ready for review November 8, 2023 09:58
@gkjohnson gkjohnson requested a review from Mugen87 November 8, 2023 10:05
@gkjohnson gkjohnson merged commit a8b8ce7 into mrdoob:dev Nov 8, 2023
19 checks passed
@gkjohnson gkjohnson deleted the batched-object-bounds branch November 8, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants