TextureUtils: Fix invalid texture data after decompression. #27137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Are these changes published somewhere so I can test? |
|
You can use rawgit for testing. The Export: https://rawcdn.githack.com/mrdoob/three.js/dev/examples/misc_exporter_gltf.html Be aware that sometimes old code might be cached when using rawgit. If you want to be on the safe side, use commit hashes inside the URLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27100
Description
When directly calling
forceContextLoss()after the decompression, the renderer's canvas gets invalid before the export happens. Hence,decompress()creates a new canvas now and copies the contents from the renderer's DOM element. This is the same way the editor handles compressed textures in itsrenderToCanvas()helper function.